ScarriffleandClaude Opus 5
ab2328969e
Calendarr already publishes an event snapshot into its App Group container for the widgets to render. That channel is what a second Mac app needs too, so this turns an internal detail into a documented contract rather than something a second app reverse-engineers and then drifts from. Foundation only — no SwiftUI, no UIKit, no AppKit — so one source compiles for iOS, Mac Catalyst and native macOS. Building against the native macOS SDK is the point: it fails loudly on a UIKit leak that a Catalyst build would accept. Three things earn their place here rather than being copied per app: CalendarrAppGroup resolves the container identifier per platform. macOS requires the Team ID prefix and iOS forbids it, and a mismatch fails silently — nil container, every read and write a no-op, widgets blank forever. CalendarKey normalises the two ways the server reports calendar_id (bare for CalDAV, "local-3" style for everything else). Normalising them differently is what made per-calendar filtering quietly do nothing for some sources. The snapshot schema is versioned, with the coverage window now explicit. That window is the easiest thing to get wrong downstream: outside it the snapshot carries no information, which is not the same as no events, and rendering an empty week for an uncovered date produces a screen that looks right and is false. covers() exists so consumers can tell the two apart. Reads return a named result rather than an optional. "Never ran", "signed out", "too new to read" and "unreadable" need different messages, and a bare nil is how the App Group misconfiguration used to hide. Writing is behind @_spi(Writer) so a read-only consumer cannot corrupt the shared cache. Writes post a Darwin notification, the one cross-process signal that works between two sandboxed apps without an extra entitlement. The six colour values stay flat on the wire instead of nesting under `theme`, which would read better. A v1 reader requires them flat, so nesting would have broken every older build on the first v2 write; `theme` is a computed view. Tests pin both directions of compatibility, since the two apps ship independently. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
52 lines
2.1 KiB
Swift
52 lines
2.1 KiB
Swift
import Testing
|
|
@testable import CalendarrCore
|
|
|
|
/// The server reports `calendar_id` two different ways, and normalising them
|
|
/// inconsistently is what made per-calendar filtering silently do nothing for
|
|
/// some sources. These pin the rule down.
|
|
struct CalendarKeyTests {
|
|
|
|
@Test("CalDAV ids arrive bare and are used as-is")
|
|
func bareNumericId() {
|
|
#expect(CalendarKey.make(source: "caldav", calendarId: "12") == "caldav:12")
|
|
}
|
|
|
|
@Test("Prefixed ids from the other sources get the prefix stripped")
|
|
func strippedPrefix() {
|
|
#expect(CalendarKey.make(source: "local", calendarId: "local-3") == "local:3")
|
|
#expect(CalendarKey.make(source: "google", calendarId: "google-5") == "google:5")
|
|
#expect(CalendarKey.make(source: "ical", calendarId: "ical-7") == "ical:7")
|
|
#expect(CalendarKey.make(source: "homeassistant",
|
|
calendarId: "homeassistant-9") == "homeassistant:9")
|
|
}
|
|
|
|
@Test("Both spellings of the same calendar produce the same key")
|
|
func bothFormsAgree() {
|
|
#expect(CalendarKey.make(source: "local", calendarId: "local-3")
|
|
== CalendarKey.make(source: "local", calendarId: "3"))
|
|
}
|
|
|
|
@Test("Only a leading prefix is stripped, and only once")
|
|
func stripsOnlyLeadingPrefix() {
|
|
// A prefix appearing later in the id must survive untouched.
|
|
#expect(CalendarKey.make(source: "local", calendarId: "3-local") == "local:3-local")
|
|
// Two prefixes: only the first goes.
|
|
#expect(CalendarKey.make(source: "local", calendarId: "local-local-3") == "local:local-3")
|
|
}
|
|
|
|
@Test("parse round-trips make")
|
|
func roundTrip() {
|
|
let key = CalendarKey.make(source: "local", calendarId: "local-42")
|
|
let parsed = CalendarKey.parse(key)
|
|
#expect(parsed?.source == "local")
|
|
#expect(parsed?.id == 42)
|
|
}
|
|
|
|
@Test("parse rejects what it cannot represent")
|
|
func rejectsMalformed() {
|
|
#expect(CalendarKey.parse("nocolon") == nil)
|
|
#expect(CalendarKey.parse("local:abc") == nil) // non-numeric id
|
|
#expect(CalendarKey.parse("local:") == nil)
|
|
}
|
|
}
|